facts['virtual'] -> is_container

Facter doesn't recognize buildah containers.

manifests/base/bootloader/systemd.pp

 class nest::base::bootloader::systemd {
-  if $facts['virtual'] == 'lxc' or $facts['os']['architecture'] =~ /^(arm|aarch64)/ {
+  if $::is_container or $facts['os']['architecture'] =~ /^(arm|aarch64)/ {
     $bootctl_args = '--no-variables'
   } else {
     $bootctl_args = ''

manifests/base/containers.pp

 class nest::base::containers {
-  service { 'docker':
-    ensure => stopped,
-    enable => false,
-  }
-  ->
-  package { 'app-emulation/docker':
-    ensure => absent,
-  }
-  ->
-  file { '/usr/bin/docker':
-    ensure => absent,
-  }
-
-
-  zfs { 'containers':
-    name       => "${facts['rpool']}/containers",
-    mountpoint => '/var/lib/containers',
+  unless $::is_container {
+    zfs { 'containers':
+      name       => "${facts['rpool']}/containers",
+      mountpoint => '/var/lib/containers',
+    }
   }
 
   package { [

manifests/base/portage.pp

@@ -70,7 +70,7 @@ class nest::base::portage {
   }
 
   if $facts['os']['architecture'] =~ /^(arm|aarch64)/ {
-    if $facts['virtual'] == 'lxc' {
+    if $::is_container {
       $sandbox_features = ['-sandbox', '-usersandbox', '-pid-sandbox', '-network-sandbox']
     } else {
       $sandbox_features = []

manifests/base/users.pp

@@ -142,7 +142,7 @@ class nest::base::users {
           group  => 'users';
       }
 
-      if $facts['virtual'] == 'lxc' {
+      if $::is_container {
         $user_homes = {}
       } else {
         $user_homes = { 'james' => '/home/james' }

manifests/base/zfs.pp

@@ -113,7 +113,7 @@ class nest::base::zfs {
 
   ::nest::lib::systemd_reload { 'zfs': }
 
-  unless $facts['virtual'] == 'lxc' {
+  unless $::is_container {
     # Manage swap volume properties for experimenting with workarounds listed in
     # https://github.com/openzfs/zfs/issues/7734
     zfs { "${facts['rpool']}/swap":

manifests/lib/srv.pp

@@ -4,18 +4,23 @@ define nest::lib::srv (
   Optional[String] $owner = undef,
   Optional[String] $group = undef,
 ) {
-  ensure_resource('zfs', 'srv', {
-    'name'       => "${facts['rpool']}/srv",
-    'mountpoint' => '/srv',
-  })
+  unless $::is_container {
+    ensure_resource('zfs', 'srv', {
+      'name'       => "${facts['rpool']}/srv",
+      'mountpoint' => '/srv',
+    })
 
-  if $zfs {
-    zfs { "srv/${name}":
-      name       => "${facts['rpool']}/srv/${name}",
-      mountpoint => "/srv/${name}",
-      require    => Zfs['srv'],
-      before     => File["/srv/${name}"],
+    if $zfs {
+      zfs { "srv/${name}":
+        name       => "${facts['rpool']}/srv/${name}",
+        mountpoint => "/srv/${name}",
+        require    => Zfs['srv'],
+        before     => File["/srv/${name}"],
+      }
     }
+
+    Zfs['srv']
+    -> File["/srv/${name}"]
   }
 
   file { "/srv/${name}":
@@ -23,6 +28,5 @@ define nest::lib::srv (
     mode    => $mode,
     owner   => $owner,
     group   => $group,
-    require => Zfs['srv'],
   }
 }

manifests/lib/systemd_reload.pp

 define nest::lib::systemd_reload {
-  $exec_noop = $facts['virtual'] == 'lxc'
-
   exec { "systemd-daemon-reload-${name}":
     command     => '/bin/systemctl daemon-reload',
     refreshonly => true,
-    noop        => $exec_noop,
+    noop        => $::is_container,
   }
 }

site.pp

@@ -11,7 +11,7 @@ unless defined('$role') {
 
 case $facts['osfamily'] {
   'Gentoo': {
-    $is_container = $facts['virtual'] == 'lxc'
+    $is_container = $facts['virtual'] == 'lxc' or $facts['build']
 
     Service {
       provider => systemd,