PDK: Fix rubocop violations

.fixtures.yml

+---
 fixtures:
   forge_modules:
     stdlib: 'puppetlabs/stdlib'

.rubocop.yml

@@ -18,6 +18,7 @@ AllCops:
   - "**/Puppetfile"
   - "**/Vagrantfile"
   - "**/Guardfile"
+  - lib/puppet/provider/package/cygwin.rb
 Layout/LineLength:
   Description: People have wide screens, use them.
   Max: 200

.sync.yml

-# This file can be used to customize the files managed by PDK.
-#
-# See https://github.com/puppetlabs/pdk-templates/blob/main/README.md
-# for more information.
-#
-# See https://github.com/puppetlabs/pdk-templates/blob/main/config_defaults.yml
-# for the default values.
---- {}
+---
+.rubocop.yml:
+  default_configs:
+    AllCops:
+      Exclude:
+        - 'lib/puppet/provider/package/cygwin.rb'

lib/facter/gentoo_news_count.rb

 Facter.add('gentoo_news_count') do
-  confine :osfamily => 'Gentoo'
+  confine osfamily: 'Gentoo'
   setcode do
     Facter::Core::Execution.execute('/usr/bin/eselect news count').to_i
   end

lib/facter/is_container.rb

 Facter.add('is_container') do
-  confine :kernel => 'Linux'
+  confine kernel: 'Linux'
   setcode do
     Facter.value(:virtual) == 'lxc' or File.exist? '/run/.containerenv'
   end

lib/facter/machine_id.rb

 Facter.add('machine_id') do
-  confine :kernel => 'Linux'
+  confine kernel: 'Linux'
   setcode do
     if File.exist?('/etc/machine-id')
       File.readlines('/etc/machine-id').map(&:chomp).first

lib/facter/podman_version.rb

 Facter.add('podman_version') do
-  confine :kernel => 'Linux'
+  confine kernel: 'Linux'
   setcode do
     if File.exist?('/usr/bin/podman')
-      $1 if Facter::Core::Execution.execute('/usr/bin/podman --version') =~ /podman version (\S+)/
+      Regexp.last_match(1) if Facter::Core::Execution.execute('/usr/bin/podman --version') =~ %{podman version (\S+)}
     end
   end
 end

lib/facter/profile.rb

 Facter.add('profile') do
-  confine :osfamily => 'Gentoo'
+  confine osfamily: 'Gentoo'
   setcode do
     profile = Facter::Core::Execution.execute('/usr/bin/eselect --brief profile show')
     case profile
     when %r{nest:(\S+)/(\S+)/(\S+)}
-      { :cpu => $1, :platform => $2, :role => $3 }
+      { cpu: Regexp.last_match(1), platform: Regexp.last_match(2), role: Regexp.last_match(3) }
     when %r{nest:(\S+)/(\S+)}
-      { :cpu => $1, :platform => $1, :role => $2 }
+      { cpu: Regexp.last_match(1), platform: Regexp.last_match(1), role: Regexp.last_match(2) }
     end
   end
 end
 
 Facter.add('profile') do
-  confine :osfamily => 'windows'
+  confine osfamily: 'windows'
   setcode do
-    { :role => 'workstation' }
+    { role: 'workstation' }
   end
 end

lib/facter/rpool.rb

 Facter.add('rpool') do
-  confine :kernel => 'Linux'
+  confine kernel: 'Linux'
   setcode do
     hostname = Facter.value('hostname')
     if File.exist?('/sbin/zfs')
+      require 'English'
       ["#{hostname}/crypt", hostname].each do |name|
         Facter::Core::Execution.execute("/sbin/zfs list #{name}")
-        break name if $? == 0
+        break name if $CHILD_STATUS == 0
       end
     else
       hostname

lib/facter/running_live.rb

 Facter.add('running_live') do
-  confine :kernel => 'Linux'
+  confine kernel: 'Linux'
   setcode do
     Facter.value(:mountpoints)['/']['device'] == 'LiveOS_rootfs'
   end